Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #12

Merged
merged 57 commits into from
Jul 22, 2024
Merged

Refactoring #12

merged 57 commits into from
Jul 22, 2024

Conversation

Venator2013
Copy link
Collaborator

No description provided.

Sven Jäger added 30 commits July 12, 2024 06:31
chore: Refactor navteq_plugin.cpp to use const reference for dataDirs
5ec5361
add converter
6f151ae
extract water ways and bodies
e33ac69
chore: Refactor Converter.cpp and Converter.hpp
1259658
extract Railways
23a26d4
add building converter
962acd0
chore: Update file associations in .vscode/settings.json
02f243d
add rest areas
58cc1fd
add hamletconverter
f5c8b22
add CityConverter
e5e18b1
add LanduseConverter
5bb62e6
extract admin boundaries
7e2151c
add adminboundaries converter
c338c6e
move iso parse logic to converter
428b255
Extract admin boundaries and refactor AdminBoundariesConverter
5ed90fd
Refactor code to add LINK_ID constant in Converter.hpp and remove LIN…
03b5716 
…K_ID constant in AdminBoundariesConverter.hpp
Refactor code to remove unused variables and improve code readability
5b13a1d
rfactoring
360b666
refactoring
1c08a0e
add housenumber
4f77e8b
refactor navteq.hpp to remove unused code and improve readability
c269b05
Refactor navteq_mappings.hpp to remove unused code and improve readab…
2e878b5 
…ility
Refactor navteq_plugin.hpp to remove unused code and improve readability
3940346
replace with std::fileystem
80d1b3a
Refactor StreetConverter to remove unused code and improve readability
fcc282e
use gdal to access dbf files
bee78f4
refactor: Remove boost-filesystem dependency and use std::filesystem …
c5c6245 
…instead
Refactor Converter class to handle navteq admin level as string
6f62681
remove helper
e2bafd3
fix datasource
705852a
Sven Jäger added 27 commits July 16, 2024 11:01
convert everything except streets
a525bf9
single directory in the converter
41cd71a
use Here to ISO mapping to determine the region to convert
80c92fa
activate streetconverter again
76d0abf
refactor: Remove navteq_mappings.hpp file
1ace21b
extract OSMTagger and housenumber creation
4c79847
more extraction
dcf5a6b
remove global under construction map
b8490e6
refactor: replace global maps
988f50b
Extract Housenumber conversion into its on converter
45cc703
extract more global states
b9fad6b
finished refactoring
82bcd5d
fix error
77c4b40
fix error with ramp names
3f7dd96
use global endpoint map
dcc1c89
add country codes
0333ebf
fix query
bacc45e
add missing region
b964fac
chore: Store considered conditional modifications in cdms_map
2b77804
ignore timerestrictions
8c63a35
fix country detection
a32d651
only consider adminlvl 1 for mapping aracoe to govcode
db4ab84
cnsider MPH
60c3db8
consider special speed limits
ed9fb2e
no direction for access restriction
7df0a7b
chore: Remove unused dependencies and update CMakeLists.txt
9895b28
remove useless BK road handling for sweden
91becff
@Venator2013 Venator2013 marked this pull request as ready for review July 22, 2024 19:49
@Venator2013 Venator2013 merged commit 0c95c3c into master Jul 22, 2024
1 check passed
@Venator2013 Venator2013 deleted the refactoring branch July 22, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Venator2013